This revision was automatically updated to reflect the committed changes.
Closed by commit rG2cc7463c85c0: [pseudo] Perform unconstrained reduction prior
to recovery. (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D130523?vs=447487=453972#toc
Repository:
rG LLVM
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:621
// Consume the token.
glrShift(Heads, Terminals[I], Params, Lang, NextHeads);
hokein wrote:
> hokein wrote:
> > I think
hokein added inline comments.
Comment at: clang-tools-extra/pseudo/lib/GLR.cpp:621
// Consume the token.
glrShift(Heads, Terminals[I], Params, Lang, NextHeads);
hokein wrote:
> I think we can move the Line634 `Heads.resize(HeadsPartition)` before the
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/pseudo/include/clang-pseudo/grammar/LRTable.h:109
+// tok::unknown is a sentinel value used in recovery: can follow anything.
+if
sammccall added a comment.
Apart from this patch, the main other things we need to allow missing brackets
to be inferred:
- allow recovery to trigger subsequent recovery, even at EOF. (Simplest way is
to address the FIXME at 660, it's pretty involved)
- allow opaque nodes to represent
sammccall updated this revision to Diff 447487.
sammccall added a comment.
restore removed debug
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130523/new/
https://reviews.llvm.org/D130523
Files:
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, alextsao1999.
Herald added a project: clang-tools-extra.
Our GLR uses lookahead: only perform reductions that might
