[PATCH] D130827: [clang] Fixed a number of typos

h-vetinari added a comment. Thanks for chasing these down! Comment at: clang/include/clang/Basic/SourceManager.h:1922 +/// SourceManager and necessary dependencies (e.g. VFS, FileManager) for a +/// single in-memorty file. class SourceManagerForFile { Even

[PATCH] D130827: [clang] Fixed a number of typos

aaron.ballman added a comment. In D130827#3691371 , @GabrielRavier wrote: >> Do you need someone to land this on your behalf? > > I assume so since landing seems to mean pushing the commit to the repo which > I'm pretty sure I don't have the rights to

[PATCH] D130827: [clang] Fixed a number of typos

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5674a3c88088: Fixed a number of typos (authored by GabrielRavier, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added a comment. > Do you need someone to land this on your behalf? Yes. > If so, what name and email address would you like used for patch attribution? `Gabriel Ravier`, `gabrav...@gmail.com` (By the way, is there any way to make this information part of my Phabricator account

[PATCH] D130827: [clang] Fixed a number of typos

aaron.ballman added a comment. Thanks for the typo fixes! All the changes look correct to me, so LGTM. Do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution? Comment at:

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult , bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining =

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier updated this revision to Diff 448858. GabrielRavier added a comment. Reverted reversion of `git clang-format` on `clang/include/clang/Sema/Sema.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/ https://reviews.llvm.org/D130827 Files:

[PATCH] D130827: [clang] Fixed a number of typos

junaire added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult , bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining = QualType(),

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4022 + ExprResult , bool DoFunctionPointerConversion = false, + bool Complain = false, SourceRange OpRangeForComplaining = SourceRange(), + QualType DestTypeForComplaining =

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier updated this revision to Diff 448850. GabrielRavier added a comment. Fixed it so that it doesn't accidentally revert all the changes made since my original diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130827/new/

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added inline comments. Comment at: clang/lib/Headers/opencl-c.h:17856 +intel_sub_group_avc_sic_payload_t __ovld intel_sub_group_avc_sic_configure_ipe( +uchar luma_intra_partition_mask, uchar intra_neighbour_availability, uchar left_edge_luma_pixels, uchar

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier added a comment. Ooh yeah looks like there's some damage. Shouldn't have done this at 12:30 AM without looking at what that `git rebase` on the latest pull ended up doing... I'll go fix this asap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130827: [clang] Fixed a number of typos

junaire added a comment. Hi, I think the main issue is that your patch contains another patch unintentionally, please fix that :) Comment at: clang/CMakeLists.txt:513 -endif() - option(CLANG_ENABLE_ARCMT "Build ARCMT." ON) Why delete these lines?

[PATCH] D130827: [clang] Fixed a number of typos

GabrielRavier created this revision. Herald added subscribers: steakhal, martong, arphaman, whisperity, mgorny. Herald added a reviewer: aaron.ballman. Herald added a reviewer: dang. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. GabrielRavier