[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

ASDenysPetrov added a comment. @martong This solution has an essential logical mistake. It relies on the erroneous assumption that if `x > 0 && x != y` then `y` is in range `[MIN, 0]` but that's **not** true. `x` and `y` could be `1` and `2` respectively. My idea will only work with concrete

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

martong added inline comments. Comment at: clang/test/Analysis/range-inferring-from-disequality-map.cpp:50-51 +if(x != tmp1 && x != tmp2) + // TODO: This condition should be infeasible. + // Thus, the branch should be unreachable. +

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

ASDenysPetrov added a comment. In D131006#3699017 , @martong wrote: > Awesome! Thank you! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1512-1516 +if (IsFirst) { + IsFirst = false; +

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

martong added inline comments. Comment at: clang/test/Analysis/range-inferring-from-disequality-map.cpp:10-11 + clang_analyzer_value(x); // expected-warning {{32s:{ [0, 0] }}} + // TODO: TODO: Keep x range correct even if associated disequalities are + // already dead. +

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

martong added a comment. Awesome! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1512-1516 +if (IsFirst) { + IsFirst = false; + RS = *RSPtr; +} else + RS = RangeFactory.unite(RS, *RSPtr); `unite`

[PATCH] D131006: [analyzer] Use DisequalityMap while inferring constraints

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: martong, steakhal, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: manas, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: