[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM, thanks @CarolineConcatto. Please land D132137 before landing this one to avoid regressions on combines that previously worked on svget/svset.

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen added a comment. Thanks for addressing the comments @CarolineConcatto! In D131547#3731310 , @dmgreen wrote: >> Is there a formal requirement that LLVM must remain backward compatible with >> older LLVM IR (beyond the target-independent

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

dmgreen added a comment. > Is there a formal requirement that LLVM must remain backward compatible with > older LLVM IR (beyond the target-independent parts)? We have always done it in the past, and I don't see a good reason to change. This change is essentially for llvm 16, so we are talking

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen added a comment. In D131547#3728867 , @dmgreen wrote: > In D131547#3728842 , @sdesmalen > wrote: > >> In D131547#3723083 , @dmgreen >> wrote: >> >>> I think

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

dmgreen added a comment. In D131547#3728842 , @sdesmalen wrote: > In D131547#3723083 , @dmgreen wrote: > >> I think we usually try to do the same, if the intrinsics have been in >> released compilers. There is

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen added a comment. In D131547#3723083 , @dmgreen wrote: > I think we usually try to do the same, if the intrinsics have been in > released compilers. There is an example in > https://reviews.llvm.org/D98487#change-tOTTgECYYAO5, hopefully these

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

dmgreen added a comment. I think we usually try to do the same, if the intrinsics have been in released compilers. There is an example in https://reviews.llvm.org/D98487#change-tOTTgECYYAO5, hopefully these would be equally simple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

RKSimon added a comment. In D131547#3712509 , @CarolineConcatto wrote: >> Are you intending to AutoUpgrade the existing intrinsics in IR? > > @RKSimon > AFAIK we want to remove them altogether. > It is not expected that external projects depend on

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

CarolineConcatto added a comment. > Are you intending to AutoUpgrade the existing intrinsics in IR? @RKSimon AFAIK we want to remove them altogether. It is not expected that external projects depend on these intrinsics. It is a legacy intrinsic that was introduced before we had vector.extract

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9077 +Value *CodeGenFunction::EmmitSVESetTuples(const SVETypeFlags , + llvm::Type *Ty, nit: s/Emmit/Emit/ How about naming these: *

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

nlopes added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9114 + unsigned int MinElts = SrcTy->getElementCount().getKnownMinValue(); + Value *Call = llvm::UndefValue::get(VTy); + for (unsigned int I = 0; I < Ops.size(); I++) { Please use

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

RKSimon added a comment. Are you intending to AutoUpgrade the existing intrinsics in IR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131547/new/ https://reviews.llvm.org/D131547 ___ cfe-commits