[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

2022-08-11 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added a comment. In D131645#3716508 , @li.zhe.hua wrote: > In D131645#3716464 , @xazax.hun > wrote: > >> probably you are already aware of most of this > > Actually, more likely than not I don't! I

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

2022-08-11 Thread Eric Li via Phabricator via cfe-commits
li.zhe.hua added a comment. In D131645#3716464 , @xazax.hun wrote: > probably you are already aware of most of this Actually, more likely than not I don't! I don't have a strong background in PL (or, really any background), so I'm really just learning

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

2022-08-11 Thread Eric Li via Phabricator via cfe-commits
li.zhe.hua updated this revision to Diff 451887. li.zhe.hua marked an inline comment as done. li.zhe.hua added a comment. Add FIXME Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131645/new/ https://reviews.llvm.org/D131645 Files:

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

2022-08-11 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. Very cool! Thanks for investing into fixing the soundness issues! A couple of ideas for the future (probably you are already aware of most of this, but open communication can help other members of the community to jump in): - Some

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

2022-08-11 Thread Eric Li via Phabricator via cfe-commits
li.zhe.hua marked an inline comment as done. li.zhe.hua added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:119 + std::unique_ptr AST = + tooling::buildASTFromCodeWithArgs("int x = 0;", {"-std=c++11"}); +

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

2022-08-11 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:119 + std::unique_ptr AST = + tooling::buildASTFromCodeWithArgs("int x =

[PATCH] D131645: [clang][dataflow] Allow user-provided lattices to provide a widen operator

2022-08-10 Thread Eric Li via Phabricator via cfe-commits
li.zhe.hua created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In order to better support convergence in