[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

2022-08-18 Thread Craig Topper via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG37c47b2cacae: [RISCV] Change how mtune aliases are implemented. (authored by craig.topper). Changed prior to commit:

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

2022-08-18 Thread Philip Reames via Phabricator via cfe-commits
reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/ReleaseNotes.rst:197 + +- ``sifive-7-rv32`` and ``sifive-7-rv64`` are no longer supported for `-mcpu`. + Can you given any

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

2022-08-18 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 453746. craig.topper added a comment. Add release note about sifive-7-rv32/64 being removed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131708/new/ https://reviews.llvm.org/D131708 Files:

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

2022-08-17 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. This seems like a sensible direction to me - let's discuss in the sync-up call this Thursday to check everyone is on-board and doesn't have concerns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131708/new/

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

2022-08-15 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 452889. craig.topper added a comment. Handle TUNE_PROC in checkTuneCPUKind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131708/new/ https://reviews.llvm.org/D131708 Files:

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

2022-08-15 Thread Craig Topper via Phabricator via cfe-commits
craig.topper planned changes to this revision. craig.topper added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:27 // RUN: %clang --target=riscv64 -### -c %s 2>&1 -mtune=rocket | FileCheck -check-prefix=MTUNE-ROCKET-64 %s -// MTUNE-ROCKET-64: "-tune-cpu"

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

2022-08-15 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng added inline comments. Comment at: clang/test/Driver/riscv-cpus.c:27 // RUN: %clang --target=riscv64 -### -c %s 2>&1 -mtune=rocket | FileCheck -check-prefix=MTUNE-ROCKET-64 %s -// MTUNE-ROCKET-64: "-tune-cpu" "rocket-rv64" - -// RUN: %clang --target=riscv32 -### -c

[PATCH] D131708: [RISCV] Change how mtune aliases are implemented.

2022-08-11 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: jrtc27, asb, luismarques, kito-cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, jeroen.dobbelaere, StephenFan, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,