[PATCH] D132275: [clang] Reset some attributed calling lambda

2022-08-22 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. In D132275#3740822 , @efriedma wrote: > In D132275#3740802 , @vitalybuka > wrote: > >> In D132275#3740479 , @efriedma >> wrote: >> >>> Among

[PATCH] D132275: [clang] Reset some attributed calling lambda

2022-08-22 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. In D132275#3740802 , @vitalybuka wrote: > In D132275#3740479 , @efriedma > wrote: > >> Among other things, we could use a definition from a different module. > > Is this a thing, I

[PATCH] D132275: [clang] Reset some attributed calling lambda

2022-08-22 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. In D132275#3740479 , @efriedma wrote: > Among other things, we could use a definition from a different module. Is this a thing, I assumed lambda is always defined in the module? > Either we relax the requirements globally

[PATCH] D132275: [clang] Reset some attributed calling lambda

2022-08-22 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. Given that we mark up lambdas with the requirement that the pointer is nonnull/noundef/dereferenceable, we can't fix that by just messing with the attributes. Among other things, we could use a definition from a different module. Either we relax the requirements

[PATCH] D132275: [clang] Reset some attributed calling lambda

2022-08-20 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 454176. vitalybuka added a comment. remove dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132275/new/ https://reviews.llvm.org/D132275 Files: clang/lib/CodeGen/CGClass.cpp

[PATCH] D132275: [clang] Reset some attributed calling lambda

2022-08-20 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 454175. vitalybuka added a comment. fix for result slot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132275/new/ https://reviews.llvm.org/D132275 Files: clang/lib/CodeGen/CGClass.cpp

[PATCH] D132275: [clang] Reset some attributed calling lambda

2022-08-19 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lambda invoker sets this argument to Undef, making it inconsistent with noundef, notnull, and dereferencable