[PATCH] D132379: [Support] Class for response file expansion

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e491c48d6b9: [Support] Class for response file expansion (NFC) (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/

[PATCH] D132379: [Support] Class for response file expansion

sepavloff added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132379: [Support] Class for response file expansion

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 ___

[PATCH] D132379: [Support] Class for response file expansion

sepavloff added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:2098 +public: + ExpansionContext(StringSaver , TokenizerCallback T, + llvm::vfs::FileSystem *FS = nullptr); rnk wrote: > StringSaver is a stateless class that

[PATCH] D132379: [Support] Class for response file expansion

sepavloff updated this revision to Diff 462528. sepavloff added a comment. Address reviewer's notes - Pass BumpPtrAllocator instead of StringSaver, - Use setter to specify file system object. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132379: [Support] Class for response file expansion

rnk added a comment. This makes sense to me. This probably affects nobody, but this reminds me of my first LLVM change: https://github.com/llvm/llvm-project/commit/fc8a2d5a8390952029e1c47a623e046b744f44d4 Comment at: llvm/include/llvm/Support/CommandLine.h:2098 +public: +

[PATCH] D132379: [Support] Class for response file expansion

sepavloff updated this revision to Diff 459403. sepavloff added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 Files: clang/lib/Driver/Driver.cpp

[PATCH] D132379: [Support] Class for response file expansion

sepavloff updated this revision to Diff 456396. sepavloff added a comment. Move change for VFS support into separate patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 Files:

[PATCH] D132379: [Support] Class for response file expansion

sepavloff added a comment. In D132379#3740102 , @thakis wrote: > Can you say what you're trying to do? There is an intention to extend algorithm of included files search. In particular it requires passing down paths where config files may be searched

[PATCH] D132379: [Support] Class for response file expansion

thakis added a comment. Can you say what you're trying to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132379/new/ https://reviews.llvm.org/D132379 ___ cfe-commits mailing list

[PATCH] D132379: [Support] Class for response file expansion

sepavloff created this revision. sepavloff added reviewers: rjmccall, kadircet, jackoalan, thakis, rnk. Herald added a subscriber: hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald added projects: clang,