[PATCH] D132592: [Clang] Implement function attribute nouwtable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70248bfdea6c: [Clang] Implement function attribute nouwtable (authored by ychen). Changed prior to commit:

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen updated this revision to Diff 456403. ychen added a comment. - add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/ https://reviews.llvm.org/D132592 Files: clang/docs/ReleaseNotes.rst

[PATCH] D132592: [Clang] Implement function attribute nouwtable

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note for the new attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen added a comment. In D132592#3751561 , @aaron.ballman wrote: > In D132592#3749567 , @ychen wrote: > >> Thanks for taking a look! >> >> In D132592#3749261 , >>

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen updated this revision to Diff 456069. ychen added a comment. - change from `FunctionLike` to `Function` - add a Sema test - update doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/ https://reviews.llvm.org/D132592 Files:

[PATCH] D132592: [Clang] Implement function attribute nouwtable

aaron.ballman added a comment. In D132592#3749567 , @ychen wrote: > Thanks for taking a look! > > In D132592#3749261 , @aaron.ballman > wrote: > >> Do we have any evidence that users need this level of control

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen added a comment. Thanks for taking a look! In D132592#3749261 , @aaron.ballman wrote: > Do we have any evidence that users need this level of control or will > understand how to properly use the attribute? The command line option makes > sense

[PATCH] D132592: [Clang] Implement function attribute nouwtable

aaron.ballman added a comment. Do we have any evidence that users need this level of control or will understand how to properly use the attribute? The command line option makes sense to me because it's an all-or-nothing flag, but I'm not certain I understand the need for per-function control.

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen updated this revision to Diff 455395. ychen added a comment. Herald added a subscriber: jdoerfert. - update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/ https://reviews.llvm.org/D132592 Files:

[PATCH] D132592: Clang] Implement function attribute nouwtable

ychen created this revision. ychen added reviewers: aaron.ballman, rnk, rsmith. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To have finer control of IR uwtable attribute generation. For target code