This revision was automatically updated to reflect the committed changes.
Closed by commit rG90bbe97036a1: [clang-tidy]
Readability-container-data-pointer adds new option to ignore… (authored by
felix642, committed by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
felix642 added a comment.
Hi @PiotrZSL,
I have made the requested changes. If everything looks good to you would you
mind committing this patch for me as I don't have commit access to the
repository. Thank you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
felix642 updated this revision to Diff 530360.
felix642 added a comment.
Updated documentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
Files:
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
LGTM (+-)
- Before committing rebase this on top of main branch (looks like this base on
previous release branch.
- Keep in mind 80 characters limit for documentation files
felix642 updated this revision to Diff 529485.
felix642 added a comment.
Improved documentation
Removed duplicated messages in tests.
Added support for regular expressions
Added method to store options.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
PiotrZSL requested changes to this revision.
PiotrZSL added a comment.
This revision now requires changes to proceed.
Overall ok, but:
- add storeOptions method
- clarify documentation for added option
- consider supporting regexes
- simplify tests, to avoid duplicating warning message
felix642 added a comment.
ping?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
felix642 updated this revision to Diff 469831.
felix642 added a comment.
Updated ReleaseNotes.rst
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
Files:
felix642 updated this revision to Diff 469830.
felix642 added a comment.
Updated documentation and code review
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
Files:
felix642 added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:26
constexpr llvm::StringLiteral AddressOfName = "address-of";
+const auto DefaultIgnoredContainers = "::std::array";
fwolff wrote:
> This is,
fwolff added a comment.
I suppose it sounds sensible to have the option of ignoring certain containers
in this check; though I haven't needed it myself so far, which is also why I'm
leaning against ignoring `std::array` by default. But I do not claim ultimate
authority on this question, of
felix642 added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
felix642 added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
felix642 added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
felix642 added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
felix642 added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp:1
-// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- --
-fno-delayed-template-parsing
+// RUN: %check_clang_tidy %s
felix642 updated this revision to Diff 458943.
felix642 added a comment.
Changed tests to check with and without config.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
Files:
Eugene.Zelenko added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp:1
-// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- --
-fno-delayed-template-parsing
+// RUN: %check_clang_tidy %s
felix642 updated this revision to Diff 458073.
felix642 added a comment.
Improved readability of release note.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
Files:
felix642 added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp:1
-// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- --
-fno-delayed-template-parsing
+// RUN: %check_clang_tidy %s
felix642 updated this revision to Diff 457829.
felix642 added a comment.
Fixed compilation issues
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
Files:
Eugene.Zelenko added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:146
+
+ The check now skips containers that are defined in the option
IgnoredContainers. The default value is ::std::array.
+
Please highlight option name and value with
felix642 updated this revision to Diff 457828.
felix642 added a comment.
+ Added test case and updated ReleaseNotes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
Files:
Eugene.Zelenko added a comment.
Please mention changes in Release Notes and add test case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133244/new/
https://reviews.llvm.org/D133244
___
cfe-commits
felix642 created this revision.
Herald added subscribers: carlosgalvezp, xazax.hun.
Herald added a project: All.
felix642 requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
25 matches
Mail list logo
