[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

erichkeane added inline comments. Comment at: clang/lib/AST/DeclTemplate.cpp:257 +return true; + case TemplateDecl::BuiltinTemplate: { +const auto *BT = cast(this); This seems strange to me that ONLY this one builtin is what makes a template a 'type

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

davrec accepted this revision. davrec added a comment. LGTM aside from a nit Comment at: clang/include/clang/AST/DeclTemplate.h:455 + bool isTypeAlias() const; + Add doc, e.g. "Whether this is a written or built-in type alias template." And nit: maybe move

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

mizvekov added a comment. In D133262#3768883 , @royjacobson wrote: > There are some known bugs about how we handle this built-in in the AST- > #42102, #51928, #54993. Is it possible that your patch solves them? It would > be great if it does, I hit

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

royjacobson added a comment. There are some known bugs about how we handle this built-in in the AST- #42102, #51928, #54993. Is it possible that your patch solves them? It would be great if it does, I hit one of them in the wild a while back. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

mizvekov updated this revision to Diff 457817. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/DeclTemplate.h

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

mizvekov updated this revision to Diff 457816. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133262/new/ https://reviews.llvm.org/D133262

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

mizvekov created this revision. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We change the template specialization of __make_integer_seq to be an alias