[PATCH] D133329: [Driver] Add --gcc-install-dir=

This revision was automatically updated to reflect the committed changes. Closed by commit rG23e4299261d9: [Driver] Add --gcc-install-dir= (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Let's tackle the config changes independently and not block this on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/

[PATCH] D133329: [Driver] Add --gcc-install-dir=

MaskRay added a comment. In D133329#3798371 , @mgorny wrote: > I think you misunderstood me. The aforementioned tests fail if I put > `--gcc-install-dir=` in the config file. There is no way to put it in the > config file that wouldn't affect these

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny added a comment. I think you misunderstood me. The aforementioned tests fail if I put `--gcc-install-dir=` in the config file. There is no way to put it in the config file that wouldn't affect these tests right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133329: [Driver] Add --gcc-install-dir=

MaskRay added a comment. In D133329#3798166 , @mgorny wrote: > Hmm, apparently this could be achieved by making it a "CoreOption". I don't think it is appropriate to have `CoreOption`. The Windows dxc support appears to have nothing to do with gcc

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny added a comment. Hmm, apparently this could be achieved by making it a "CoreOption". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329 ___ cfe-commits

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. Unfortunately, we have some test failures after this change, e.g.: FAIL: Clang :: CodeGenHLSL/basic_types.hlsl (6525 of 15795) TEST 'Clang ::

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Ok, this works fine for me (though I haven't run the tests yet). If D109621 and this one lands, I think the old Gentoo logic can be removed. We'll still

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny added a comment. At a first glance, it works. I'm now building GCC:11 here to test it against two real installations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329

[PATCH] D133329: [Driver] Add --gcc-install-dir=

MaskRay updated this revision to Diff 458065. MaskRay added a comment. improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D133329: [Driver] Add --gcc-install-dir=

MaskRay created this revision. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option specifies a GCC installation directory such as