[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

Mordante added a comment. @aaron.ballman We'd like to clean up the patches from the libc++ review queue. Is this patch is still relevant? Especially after landing https://reviews.llvm.org/D133535. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

dblaikie added subscribers: EricWF, rsmith. dblaikie added a comment. In D133425#3815118 , @aaron.ballman wrote: > In D133425#3780579 , @dblaikie > wrote: > >> > > Yeah, that might be a way forward - splitting

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

aaron.ballman added a comment. In D133425#3780579 , @dblaikie wrote: > Yeah, that might be a way forward - splitting the warning in two - have one level that's the current even-in-system-headers behavior, then a subset that's the GCC-behavior.

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

dblaikie added a comment. In D133425#3780435 , @ldionne wrote: > In D133425#3779121 , @dblaikie > wrote: > >>> One thing I don't understand in the current state of things is why the >>> diagnostic fires at all

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

ldionne added a comment. In D133425#3779121 , @dblaikie wrote: >> One thing I don't understand in the current state of things is why the >> diagnostic fires at all inside system headers. I thought warnings in system >> headers were discarded? > > It

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

dblaikie added a comment. > In D133425#3778433 , @dblaikie > wrote: > >> So previously/currently-without-this-patch the diagnostic was suppressed if >> the use of ctad was in a system header (suppression based on the >> generic/builtin diagnostic

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

ldionne added a comment. FWIW I just created https://reviews.llvm.org/D133535. IMO that is a safer alternative, in the sense that we only opt-in those types that we know are safe to use with CTAD, but the remaining classes still get a warning. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

ldionne added a comment. In D133425#3777598 , @aaron.ballman wrote: > In D133425#3775353 , @ldionne wrote: > >> Wouldn't re-applying >>

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

dblaikie accepted this revision. dblaikie added a comment. In D133425#3777615 , @aaron.ballman wrote: > In D133425#3777598 , @aaron.ballman > wrote: > >> In D133425#3775353

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

aaron.ballman added a comment. In D133425#3777598 , @aaron.ballman wrote: > In D133425#3775353 , @ldionne wrote: > >> Re-applying `fcd549a7d8284a8e7c763fee3da2206acd8cdc4f` would not require any >> Clang

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

aaron.ballman added a comment. In D133425#3775353 , @ldionne wrote: > Wouldn't re-applying > https://github.com/llvm/llvm-project/commit/fcd549a7d8284a8e7c763fee3da2206acd8cdc4f > (which had been reverted IIUC) be a more precise fix for this problem?

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

ldionne added a comment. Wouldn't re-applying https://github.com/llvm/llvm-project/commit/fcd549a7d8284a8e7c763fee3da2206acd8cdc4f (which had been reverted IIUC) be a more precise fix for this problem? We'd suppress the warning, but only for classes that we know are OK to use with CTAD. It is

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaInit.cpp:10303 // Warn if CTAD was used on a type that does not have any user-defined - // deduction guides. - if

[PATCH] D133425: Silence -Wctad-maybe-unsupported stemming from system headers

aaron.ballman created this revision. aaron.ballman added reviewers: dblaikie, ldionne, clang-language-wg, libc++. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. Currently, this diagnostic fires on system header code that the user has