This revision was automatically updated to reflect the committed changes.
Closed by commit rGe456d2ba8bca: [clang][ASTImporter]
DeclContext::localUncachedLookup: Continue lookup into… (authored by
Michael137).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Michael137 updated this revision to Diff 460718.
Michael137 added a comment.
- Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133945/new/
https://reviews.llvm.org/D133945
Files:
clang/lib/AST/DeclBase.cpp
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
LGTM, Thanks!
Comment at: clang/lib/AST/DeclBase.cpp:1781
if (Name && !hasLazyLocalLexicalLookups() &&
!hasLazyExternalLexicalLookups()) {
if
Michael137 added inline comments.
Comment at: clang/lib/AST/DeclBase.cpp:1781
if (Name && !hasLazyLocalLexicalLookups() &&
!hasLazyExternalLexicalLookups()) {
if (StoredDeclsMap *Map = LookupPtr) {
Michael137 wrote:
> Could merge the two if-blocks
Michael137 updated this revision to Diff 460429.
Michael137 added a comment.
- Undo incorrect previous change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133945/new/
https://reviews.llvm.org/D133945
Files:
clang/lib/AST/DeclBase.cpp