This revision was automatically updated to reflect the committed changes.
Closed by commit rL250064: [CMake] Bug 14109 - CMake build for compiler-rt
should use just-built clang (authored by cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D13399?vs=36897=37127#toc
Repository:
rL
beanz added inline comments.
Comment at: runtime/CMakeLists.txt:41
@@ +40,3 @@
+
+ add_custom_target(compiler-rt-clear
+DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared
samsonov wrote:
> So, that's the target that you can invoke manually to clean
samsonov added inline comments.
Comment at: runtime/CMakeLists.txt:41
@@ +40,3 @@
+
+ add_custom_target(compiler-rt-clear
+DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared
So, that's the target that you can invoke manually to clean compiler-rt build?
beanz added a comment.
I will send updated patches shortly.
Comments inline below.
Comment at: runtime/CMakeLists.txt:33
@@ -32,1 +32,3 @@
+ )
+set(cmake_3_4_USES_TERMINAL USES_TERMINAL 1)
endif()
samsonov wrote:
> Should this also be named
beanz updated this revision to Diff 36532.
beanz added a comment.
- Cleanup based on feedback from samsonov
http://reviews.llvm.org/D13399
Files:
runtime/CMakeLists.txt
Index: runtime/CMakeLists.txt
===
---
probinson added a subscriber: probinson.
probinson added a comment.
I'm a CMake ignoramus but functionally if I'm building a Clang cross-compiler,
I'd want a cross-built compiler-rt but not run its tests even if
LLVM_INCLUDE_TESTS is on. Does that make sense? If so, does this change make
beanz added a comment.
probinson,
Not by itself, but this could be used as a step in that direction. The
`CLANG_COMPILER_RT_CMAKE_ARGS` variable can be used to configure how
compiler-rt is built with a great deal of flexibility, but the goal of this
patch is to try and closely match how
