[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

2023-06-21 Thread Moth via Phabricator via cfe-commits
tigermoth added a comment. Now that AES, SHA2, SHA3 and SM4 features have been removed from armv8.6-a, these Apple CPUs can be changed again from 8.5-a to more correctly specified as armv8.6-a https://reviews.llvm.org/D141606?id=488968 CHANGES SINCE LAST ACTION

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

2023-01-28 Thread Valerii Zapodovnikov via Phabricator via cfe-commits
ValZapod added a comment. What do you mean by we do not have SM4? Apple CPU or clang? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134351/new/ https://reviews.llvm.org/D134351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

2022-09-22 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover closed this revision. t.p.northover added a comment. Thanks, committed as 677da09d0259 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134351/new/ https://reviews.llvm.org/D134351

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

2022-09-21 Thread Ahmed Bougacha via Phabricator via cfe-commits
ab accepted this revision. ab added a comment. This revision is now accepted and ready to land. > but in AArch64TargetParser.def, marking them v8.6 brings in support for the > SM4 cryptographic hash and we don't actually have that Huh, I don't understand why, does that ring a bell? Looks like

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

2022-09-21 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover updated this revision to Diff 461858. t.p.northover added a comment. Accidentally clang-formatted the `ampere1` test. Undo that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134351/new/ https://reviews.llvm.org/D134351 Files: clang/test/Misc/target-invalid-cpu-note.c

[PATCH] D134351: AArch64: add definitions for recent Apple CPUs

2022-09-21 Thread Tim Northover via Phabricator via cfe-commits
t.p.northover created this revision. t.p.northover added a reviewer: ab. Herald added subscribers: hiraditya, kristof.beyls, mcrosier. Herald added a project: All. t.p.northover requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This