[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt updated this revision to Diff 515740. RIscRIpt added a comment. A proper implementation In D134475#4224082 , @erichkeane wrote: > I don't have a good idea, I don't think any sort of RAII object is the right > way (since it will be wrong on

[PATCH] D134475: Add C++11 attribute msvc::constexpr

erichkeane added a comment. In D134475#4222805 , @RIscRIpt wrote: > I am sorry for protracting implementation. I am still interested to finish > this (if no volunteer takes over sooner). > > In D134475#4070995 ,

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt added a comment. I am sorry for protracting implementation. I am still interested to finish this (if no volunteer takes over sooner). In D134475#4070995 , @RIscRIpt wrote: > I asked MSFT >

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt added a comment. I asked MSFT to comment, let's see if they can share the spec for this attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134475: Add C++11 attribute msvc::constexpr

aaron.ballman added a comment. In D134475#3829583 , @RIscRIpt wrote: >> TODO: I think, I'll need to read more about constexpr for functions in >> standard (and LLVM code), to add relevant restrictions here. > > In the standard I was able to find the

[PATCH] D134475: Add C++11 attribute msvc::constexpr

aaron.ballman added a subscriber: cpplearner. aaron.ballman added a comment. Pulling a comment out of https://reviews.llvm.org/D133853 that's relevant here: In D133853#3844851 , @cpplearner wrote: > In D133853#3808674

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt added a comment. > TODO: I think, I'll need to read more about constexpr for functions in > standard (and LLVM code), to add relevant restrictions here. In the standard I was able to find the following paragraphs about `constexpr`: 1. Neither constructor nor destructor can be

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt planned changes to this revision. RIscRIpt added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4995-4997 + case ParsedAttr::AT_MSConstexpr: +D->addAttr(::new (S.Context) MSConstexprAttr(S.Context, AL)); +return; aaron.ballman

[PATCH] D134475: Add C++11 attribute msvc::constexpr

RIscRIpt updated this revision to Diff 464522. RIscRIpt retitled this revision from "[AST] Add C++11 attribute msvc::constexpr" to "Add C++11 attribute msvc::constexpr". RIscRIpt added a comment. Add more tests, don't alter constexprKind of `[[msvc::constexpr]]` functions - instead change