[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42b70793a1df: Reland [Clang][LoongArch] Add inline asm support

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. A polite ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/ https://reviews.llvm.org/D134638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. In D134638#3823379 , @xen0n wrote: > The previous test results (with some of my WIP patches but unrelated to this) > before the fix: > > Failed Tests (6): > LLVM :: CodeGen/AArch64/GlobalISel/irtranslator-inline-asm.ll

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463847. SixWeining added a comment. Herald added subscribers: kosarev, kerbowa, jvesely. update CodeGen/AArch64/GlobalISel/irtranslator-inline-asm.ll and CodeGen/AMDGPU/GlobalISel/irtranslator-inline-asm.ll Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

xen0n added a comment. The previous test results (with some of my WIP patches but unrelated to this) before the fix: Failed Tests (6): LLVM :: CodeGen/AArch64/GlobalISel/irtranslator-inline-asm.ll LLVM :: CodeGen/AMDGPU/GlobalISel/irtranslator-inline-asm.ll LLVM ::

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. In D134638#3822926 , @MaskRay wrote: > `Constraint_k` somehow broke AArch64 and X86 inlineasm. Please run at least > `check-llvm check-clang` for generic changes which may have farreaching > effects to other targets. Sorry

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463815. SixWeining added a comment. Herald added a subscriber: pengfei. The flag in the INLINEASM SDNode in llvm/test/CodeGen/X86/callbr-asm-kill.mir is updated because enum `Constraint_k` is added before `Constraint_m`. Repository: rG LLVM Github

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

MaskRay added a comment. `Constraint_k` somehow broke AArch64 and X86 inlineasm. Please run `check-llvm` for generic changes which may have farreaching effects to other targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7baddc7557e: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC (authored by SixWeining). Repository: rG LLVM Github Monorepo

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463408. SixWeining added a comment. Remove the first line "Assertions" in inline-asm-constraint-ZB.ll as it is not autogenerated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463404. SixWeining added a comment. Handle k and ZB in llvm/include/llvm/IR/InlineAsm.h::getMemConstraintName and add relevant tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:117 +// parsing. +R = std::string("^") + std::string(Constraint, 2); +Constraint++; MaskRay wrote: > First `std::string` can be omitted Thanks.

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463395. SixWeining marked 4 inline comments as done. SixWeining added a comment. Address comments from @rengolin and @MaskRay. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

MaskRay added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelDAGToDAG.cpp:92 + case InlineAsm::Constraint_m: { +SDValue Base, Offset; +Base = Op; Prefer initializing the variable when it is declared Comment at:

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:103 + Info.setAllowsMemory(); + Name++; // Skip over 'Z'. + return true; `++Name` Comment at: clang/lib/Basic/Targets/LoongArch.cpp:117 +//

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

rengolin accepted this revision. rengolin added a comment. Looks good, with some nits. Thanks! Comment at: llvm/lib/Target/LoongArch/LoongArchAsmPrinter.cpp:76 + // TODO: handle extra code. + if (!ExtraCode) { +const MachineOperand = MI->getOperand(OpNo);

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

xen0n accepted this revision. xen0n added a comment. This revision is now accepted and ready to land. The test cases look good to me. We should be pretty close to passing `ninja check` natively. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, rengolin, wangleiat, gonglingqin. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added