arichardson added a comment.
In case anyone else runs into this: It appears this change somehow broke
incremental builds with `-DLLVM_ENABLE_RUNTIMES=libunwind` (even after deleting
CMakeCache.txt in the main build dir):
-- Using libunwind testing configuration:
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa48f018bb7d8: [runtimes] Remove all traces of the legacy
testing configuration system (authored by ldionne).
Repository:
rG LLVM Github Monorepo
ldionne updated this revision to Diff 464351.
ldionne added a comment.
Add release note.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134650/new/
https://reviews.llvm.org/D134650
Files:
clang/cmake/caches/CrossWinToARMLinux.cmake
ldionne added inline comments.
Comment at: clang/cmake/caches/CrossWinToARMLinux.cmake:163
set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_COMPILER_RT_EMULATOR
"\\\"${Python3_EXECUTABLE}\\\"
\\\"${LLVM_PROJECT_DIR}/llvm/utils/remote-exec.py\\\" --execdir %%T
ldionne updated this revision to Diff 464234.
ldionne added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134650/new/
https://reviews.llvm.org/D134650
Files:
clang/cmake/caches/CrossWinToARMLinux.cmake
vvereschaka added inline comments.
Comment at: clang/cmake/caches/CrossWinToARMLinux.cmake:163
set(RUNTIMES_${TOOLCHAIN_TARGET_TRIPLE}_COMPILER_RT_EMULATOR
"\\\"${Python3_EXECUTABLE}\\\"
\\\"${LLVM_PROJECT_DIR}/llvm/utils/remote-exec.py\\\" --execdir %%T
ldionne updated this revision to Diff 464060.
ldionne added a comment.
Rebase on main.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134650/new/
https://reviews.llvm.org/D134650
Files:
clang/cmake/caches/CrossWinToARMLinux.cmake
ldionne added a subscriber: vvereschaka.
ldionne added a comment.
@vvereschaka Can you please confirm that the CMake cache changes look good to
you?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134650/new/
https://reviews.llvm.org/D134650
ldionne created this revision.
Herald added subscribers: libcxx-commits, mstorsjo, arichardson.
Herald added projects: libunwind, All.
Herald added a reviewer: libunwind.
ldionne requested review of this revision.
Herald added projects: clang, libc++, libc++abi.
Herald added a subscriber:
