[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tbaeder marked an inline comment as done. Closed by commit rG0ddd13acc9e9: [clang][Interp] Implement This pointer passing to methods (authored by tbaeder). Changed

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:108 - S.Current = - new InterpFrame(S, const_cast(Func), S.Current, {}, {}); + S.Current = new InterpFrame(S, const_cast(Func), {}); // Result of

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/EvalEmitter.cpp:108 - S.Current = - new InterpFrame(S, const_cast(Func), S.Current, {}, {}); + S.Current = new

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:139 + // ref-note {{in call to 'foo()'}} +}; aaron.ballman wrote: > The other thing I think we need some tests for are constructor and destructor >

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:139 + // ref-note {{in call to 'foo()'}} +}; The other thing I think we need some tests for are constructor and destructor calls where the `this`

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder updated this revision to Diff 465966. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:106 + +constexpr C RVOAndParams(const C *c) { + return C(); tbaeder wrote: > aaron.ballman wrote: > > We're missing a fair amount of test coverage here in terms of calling > >

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:106 + +constexpr C RVOAndParams(const C *c) { + return C(); aaron.ballman wrote: > We're missing a fair amount of test coverage here in terms of calling member > functions. Can you

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:638 if (const auto CtorExpr = dyn_cast(Initializer)) { -const CXXConstructorDecl *Ctor = CtorExpr->getConstructor(); -const RecordDecl *RD =

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:47 + bool HasThisPointer = false; + if (const auto *MD = dyn_cast(F); MD && !MD->isStatic()) { +HasThisPointer = true; Comment at:

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder added a comment. @aaron.ballman This one has working precommit CI \o/ (array filler patch is not needed for it though) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 ___ cfe-commits

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder updated this revision to Diff 465279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder updated this revision to Diff 464179. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Seems like I completely forgot to post this to