This revision was automatically updated to reflect the committed changes.
tomasz-kaminski-sonarsource marked an inline comment as done.
Closed by commit rG73716baa30eb: [analyzer][NFC] Add tests for D132236
(authored by tomasz-kaminski-sonarsource).
Repository:
rG LLVM Github Monorepo
CHANGES
martong accepted this revision.
martong added a comment.
This revision is now accepted and ready to land.
Thanks for the update! LGTM.
Comment at: clang/test/Analysis/trivial-copy-struct.cpp:57
+
+ // Dead code should be unreachable
+ clang_analyzer_warnIfReached(); //
tomasz-kaminski-sonarsource marked 2 inline comments as done.
tomasz-kaminski-sonarsource added inline comments.
Comment at: clang/test/Analysis/symbol-reaper-lambda.cpp:14
+escape(param, local_pre_lambda);
+return ref_captured; // no-warning: The value is not garbage.
+
tomasz-kaminski-sonarsource updated this revision to Diff 464657.
tomasz-kaminski-sonarsource added a comment.
Added requested comment for the example.
Included additional false-positive test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
martong added a comment.
Thank you! Increasing coverage in tests is always great.
Comment at: clang/test/Analysis/NewDeleteLeaks.cpp:196
+
+namespace symbol_reaper_lifetime {
+struct Nested {
Could you please add some explanation for the test case? Thinking of
tomasz-kaminski-sonarsource updated this revision to Diff 464184.
tomasz-kaminski-sonarsource added a comment.
Added new line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134941/new/
https://reviews.llvm.org/D134941
Files:
tomasz-kaminski-sonarsource created this revision.
Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy,
Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Herald added a project: All.
tomasz-kaminski-sonarsource requested review of this
