This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG62a58050ba0a: [clang][Interp] Implement bitwise and
operations (authored by tbaeder).
Changed prior to commit:
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:289
+ static_assert((1337 & -1) == 1337, "");
+ static_assert((0 & gimme(12)) == 0, "");
+};
shafik wrote:
> Why `gimme(12)` and not just `12`?
I just thought it might be useful to
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/test/AST/Interp/literals.cpp:289
+ static_assert((1337 & -1) == 1337, "");
+ static_assert((0 & gimme(12)) == 0, "");
+};
Why
tbaeder updated this revision to Diff 464902.
tbaeder marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135012/new/
https://reviews.llvm.org/D135012
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Integral.h
shafik added inline comments.
Comment at: clang/lib/AST/Interp/Integral.h:215
+ static bool band(Integral A, Integral B, unsigned OpBits, Integral *R) {
+*R = Integral(A.V & B.V);
Maybe `bitAnd`?
Comment at:
tbaeder updated this revision to Diff 464478.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135012/new/
https://reviews.llvm.org/D135012
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/Integral.h
clang/lib/AST/Interp/Interp.h
clang/lib/AST/Interp/Opcodes.td
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
