[PATCH] D135115: [clang-format] update --files help description

owenpan added inline comments. Comment at: clang/docs/ClangFormat.rst:72-73 Used only with --dry-run or -n ---files= - Provide a list of files to run clang-format +--files= - A file containing a list of

[PATCH] D135115: [clang-format] update --files help description

Herald added a subscriber: wangpc. Herald added a reviewer: rymiel. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment It looks like your clang-format review does not contain any unit tests, please try to ensure all code changes have a unit test (unless this is an `NFC` or

[PATCH] D135115: [clang-format] update --files help description

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c94f75f00af: [clang-format] update --files help description (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135115: [clang-format] update --files help description

ychen added a comment. In D135115#3839547 , @HazardyKnusperkeks wrote: > Except for the `@` part. (Which also isn't handles by clang-format, or > is it?) It is not. It is handled by the LLVM commandline library.

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. In D135115#3839547 , @HazardyKnusperkeks wrote: > It's too long ago for me. Does the `--files` option take multiple file names > on the command line, or a file containing the file names? If the latter the > patch generally

[PATCH] D135115: [clang-format] update --files help description

HazardyKnusperkeks added a comment. It's too long ago for me. Does the `--files` option take multiple file names on the command line, or a file containing the file names? If the latter the patch generally looks good. Except for the `@` part. (Which also isn't handles by clang-format, or is

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465151. ychen added a comment. - make corresponding change in the commandline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. The help text in ClangFormat.cpp for the `--files` option needs to be updated the same way. Note using `cl::value_desc("filename")` is what you need to change the meta-variable in the help output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465134. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst Index:

[PATCH] D135115: [clang-format] update --files help description

probinson added inline comments. Comment at: clang/docs/ClangFormat.rst:72-73 Used only with --dry-run or -n ---files= - Provide a list of files to run clang-format +--files= - Accept a list of response

[PATCH] D135115: [clang-format] update --files help description

MyDeveloperDay added a comment. Its Is a minor point, but when using --files, the shell will allow me to autocomplete.. clang-format -verbose -n -files ./cla clang-format -verbose -n -files ./clang/d etc... all the way to the file clang-format -verbose -n -files

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. The option handling in clang-format itself would need to be updated as well. Comment at: clang/docs/ClangFormat.rst:29 USAGE: clang-format [options] [ ...] MyDeveloperDay wrote: > if response files are so common place why not

[PATCH] D135115: [clang-format] update --files help description

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormat.rst:29 USAGE: clang-format [options] [ ...] if response files are so common place why not say it here `clang-format [options] [@file]` I personally don't believe we need to

[PATCH] D135115: [clang-format] update --files help description

ychen created this revision. ychen added reviewers: MyDeveloperDay, probinson. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. correlates the option with reponse file concept. Repository: rG LLVM