[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-11-14 Thread Muhammad Omair Javaid via Phabricator via cfe-commits
omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. Hi this broke https://lab.llvm.org/buildbot/#/builders/245/builds/761 I have reverted the change to make the buildbot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-11-10 Thread Egor Zhdan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG97105e5bf70f: [libclang] Expose completion result kind in `CXCompletionResult` (authored by egorzhdan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-11-10 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/ https://reviews.llvm.org/D136844 ___ cfe-commits mailing list

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-10-31 Thread Ben Barham via Phabricator via cfe-commits
bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. Thanks Egor! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/ https://reviews.llvm.org/D136844

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-10-31 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan updated this revision to Diff 472171. egorzhdan added a comment. Preserve `CodeCompletionResult::ResultKind` and do the conversion to `CXCompletionResultKind` in `CIndexCodeCompletion.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-10-31 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. kadircet wrote: > egorzhdan wrote: > > kadircet wrote: > > > i

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-10-31 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. egorzhdan wrote: > kadircet wrote: > > i don't follow the reason

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-10-30 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. kadircet

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-10-30 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan updated this revision to Diff 471838. egorzhdan added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix clangd compilation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-10-27 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. i don't follow the reason for replacing this struct with

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

2022-10-27 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan created this revision. egorzhdan added reviewers: arphaman, bnbarham. Herald added a subscriber: kadircet. Herald added a project: All. egorzhdan requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This allows