[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

2022-11-30 Thread Sylvain Audi via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f3438a596d4: [CodeGen][X86] Crash fixes for patchable-function pass (authored by saudi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

2022-11-28 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137642/new/ https://reviews.llvm.org/D137642 ___

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

2022-11-24 Thread Sylvain Audi via Phabricator via cfe-commits
saudi added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137642/new/ https://reviews.llvm.org/D137642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

2022-11-22 Thread Sylvain Audi via Phabricator via cfe-commits
saudi updated this revision to Diff 477182. saudi added a comment. Small update: improve comments, remove empty line modification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137642/new/ https://reviews.llvm.org/D137642 Files:

[PATCH] D137642: [X86][CodeGen] Fix crash in hotpatch

2022-11-21 Thread Sylvain Audi via Phabricator via cfe-commits
saudi updated this revision to Diff 476960. saudi added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added support for empty MBB: ensures 2-byte nop is inserted, to make the function patchable. This should also support the requirement for the functions not to