[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/HTMLReport.cpp:116 FileID File; + const FileEntry *FE; hokein wrote: > nit: the `FE` can be removed -- we have the FileID, we can

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

hokein added a comment. In D138219#3946020 , @sammccall wrote: > (I do think the outstanding issues are not related to this patch, so this is > ready for review) Agree (sorry, I didn't mean we should address in this patch). We have found a few issues,

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

sammccall added a comment. In D138219#3946020 , @sammccall wrote: > In D138219#3945954 , @hokein wrote: > >> E.g. for the following case, the `UsingShadowDecl` refers to the *primary* >> template decl, which is

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

sammccall added a comment. (I do think the outstanding issues are not related to this patch, so this is ready for review) In D138219#3945954 , @hokein wrote: > E.g. for the following case, the `UsingShadowDecl` refers to the *primary* > template decl,

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

hokein added a comment. >> we are missing refs in some using declarations (line 31, line32), but line >> 33 does have a link which seems weird > > They are different types of symbol (template vs function), may make a > difference? You're right, the template is the reason here. Taking a closing

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

sammccall added a comment. In D138219#3936279 , @hokein wrote: > Thanks, I like the idea of marking missing-include refs. > > I haven't read the code yet, and below are all my findings when I played with > the demo html (some of them are unrelated to

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

hokein added a comment. Thanks, I like the idea of marking missing-include refs. I haven't read the code yet, and below are all my findings when I played with the demo html (some of them are unrelated to the current patch, just want to dump all): 1. size_t shows duplicated entries, line 465

[PATCH] D138219: [include-cleaner] Show includes matched by refs in HTML report. Demo: https://htmlpreview.github.io/?https://gist.githubusercontent.com/sam-mccall/ecee6869e37af3db28089b64d8dce806/ra

sammccall created this revision. sammccall added a reviewer: hokein. Herald added a subscriber: mgrang. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github