[PATCH] D138274: Add version to all LLVM cmake package

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecfa2d3d9943: Add version to all LLVM cmake package (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138274: Add version to all LLVM cmake package

thopre updated this revision to Diff 477916. thopre added a comment. Use LLVM_VERSION as a CMake variable and LLVM_VERSION_* as substitutions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org/D138274 Files:

[PATCH] D138274: Add version to all LLVM cmake package

thopre reopened this revision. thopre added inline comments. This revision is now accepted and ready to land. Comment at: clang/cmake/modules/ClangConfig.cmake.in:6 +set(LLVM_VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}) +find_package(LLVM

[PATCH] D138274: Add version to all LLVM cmake package

mceier added inline comments. Comment at: clang/cmake/modules/ClangConfig.cmake.in:6 +set(LLVM_VERSION ${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}) +find_package(LLVM @LLVM_VERSION@ EXACT REQUIRED CONFIG HINTS "@CLANG_CONFIG_LLVM_CMAKE_DIR@")

[PATCH] D138274: Add version to all LLVM cmake package

This revision was automatically updated to reflect the committed changes. Closed by commit rGad485b71b511: Add version to all LLVM cmake package (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/

[PATCH] D138274: Add version to all LLVM cmake package

stellaraccident accepted this revision. stellaraccident added a comment. As mentioned, the duplication is annoying but I suspect is the least bad way to do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/

[PATCH] D138274: Add version to all LLVM cmake package

thopre added a comment. In D138274#3938218 , @arsenm wrote: > I thought we had this already. The amount of boiler plate required repeated > in each component is depressing, but I wouldn't be surprised if it's really > needed I could configure the

[PATCH] D138274: Add version to all LLVM cmake package

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. I thought we had this already. The amount of boiler plate required repeated in each component is depressing, but I wouldn't be surprised if it's really needed Repository: rG LLVM Github

[PATCH] D138274: Add version to all LLVM cmake package

thopre created this revision. thopre added reviewers: smeenai, arsenm, stella.stamenova, stellaraccident, Ericson2314, pmccormick, beanz. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov,