[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1116ed2beb1c: [clang-format] Correctly count a tabs width in a comment (authored by HazardyKnusperkeks). Changed prior to commit:

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks updated this revision to Diff 480597. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138402/new/ https://reviews.llvm.org/D138402 Files: clang/lib/Format/BreakableToken.cpp

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

owenpan accepted this revision. owenpan added a comment. Thanks for unstacking it! Comment at: clang/unittests/Format/FormatTestComments.cpp:66-67 const FormatStyle = getLLVMStyle()) { EXPECT_EQ(Code.str(), format(Code, Style)) << "Expected code is

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks updated this revision to Diff 479054. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a reviewer: klimek. HazardyKnusperkeks added a comment. Pulled the `verifyFormat` into this change. CHANGES SINCE LAST ACTION

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } owenpan wrote: > HazardyKnusperkeks wrote: > > owenpan wrote: > > > ```

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } HazardyKnusperkeks wrote: > owenpan wrote: > > ``` > > error: reference

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } owenpan

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:736 + "//* 0.2)", + "//\t\t\t\tofMap(message.velocity, 0, 127, 0, ofGetWidth() * 0.2)"); } ``` error: reference to type 'const clang::format::FormatStyle' could

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks added a comment. In D138402#3940981 , @rymiel wrote: > The behaviour of tabs still doesn't match that of spaces, but at least this > makes it idempotent. I did initially looked into that, but then asked do we want to treat tabs

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. The behaviour of tabs still doesn't match that of spaces, but at least this makes it idempotent. This also fixes https://github.com/llvm/llvm-project/issues/51808, I'm closing it as

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a