This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG821691039585: clang/cmake: Use installed gtest libraries for
stand-alone builds (authored by tstellar).
Changed prior to commit:
phosek accepted this revision.
phosek added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138472/new/
https://reviews.llvm.org/D138472
___
cfe-commits mailing list
kwk accepted this revision.
kwk added a comment.
This revision is now accepted and ready to land.
Working for me.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138472/new/
https://reviews.llvm.org/D138472
tstellar added inline comments.
Comment at: clang/CMakeLists.txt:103
if (LLVM_LIT AND LLVM_UTILS_PROVIDED)
- set(UNITTEST_DIR ${LLVM_THIRD_PARTY_DIR}/utils/unittest)
- if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h
- AND NOT EXISTS
kwk added inline comments.
Comment at: clang/CMakeLists.txt:103
if (LLVM_LIT AND LLVM_UTILS_PROVIDED)
- set(UNITTEST_DIR ${LLVM_THIRD_PARTY_DIR}/utils/unittest)
- if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h
- AND NOT EXISTS
tstellar created this revision.
tstellar added reviewers: mgorny, phosek, Ericson2314.
Herald added a project: All.
tstellar requested review of this revision.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D138472
Files:
clang/CMakeLists.txt
