Re: [PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

2015-11-09 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaCXXScopeSpec.cpp:775-787 @@ +774,15 @@ +if (ClassTemplateDecl *CTD = Found.getAsSingle()) { + TemplateParameterList *TPL = CTD->getTemplateParameters(); + assert(TPL && "NULL template parameter list"); +

Re: [PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

2015-11-09 Thread Davide Italiano via cfe-commits
davide added a comment. Gentle Monday morning ping :) Repository: rL LLVM http://reviews.llvm.org/D13854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

2015-11-01 Thread Davide Italiano via cfe-commits
davide added a comment. Gentle ping. Repository: rL LLVM http://reviews.llvm.org/D13854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13854: Template class: emit better diagnostic in case of missing template argument list

2015-10-18 Thread Davide Italiano via cfe-commits
davide created this revision. davide added a reviewer: rsmith. davide added a subscriber: cfe-commits. davide set the repository for this revision to rL LLVM. Richard, this implements what you proposed in https://llvm.org/bugs/show_bug.cgi?id=25223 , hopefully in the correct way. This is what we