ManuelJBrito added a comment.
Thanks for the review arsenm!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138755/new/
https://reviews.llvm.org/D138755
___
cfe-commits mailing list
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG481170cb5511: [Clang][CodeGen] Use poison instead of undef
for extra argument in… (authored by ManuelJBrito, committed by nlopes).
Repository:
rG
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
I think this is OK. It’s use of uninitialized value, those uninitialized values
just happen to come from inactive lanes.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ManuelJBrito edited reviewers, added: arsenm; removed: yaxunl.
ManuelJBrito added a comment.
Herald added a subscriber: wdng.
Is this change OK? It seems to me that here undef is just a placeholder. Was
hoping that some AMDGPU folks could review it.
Repository:
rG LLVM Github Monorepo
ManuelJBrito added a reviewer: yaxunl.
ManuelJBrito added a comment.
Couldn't find documentation for this intrinsic, can you shed a light on whether
or not this change is OK?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138755/new/
ManuelJBrito created this revision.
ManuelJBrito added a project: AMDGPU.
Herald added subscribers: kosarev, jvesely.
Herald added a project: All.
ManuelJBrito requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Use poison instead of undef
