This revision was automatically updated to reflect the committed changes.
Closed by commit rG1221af99281c: [clang][Interp] Use placement new to construct
opcode args into vector (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139185/new/
https://reviews.llvm.org/D139185
___
cfe-commits mailing
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139185/new/
https://reviews.llvm.org/D139185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder updated this revision to Diff 480873.
tbaeder marked 2 inline comments as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139185/new/
https://reviews.llvm.org/D139185
Files:
clang/lib/AST/Interp/ByteCodeEmitter.cpp
clang/lib/AST/Interp/PrimType.h
aaron.ballman added a comment.
Generally looks correct to me.
Comment at: clang/lib/AST/Interp/PrimType.h:65
+constexpr bool aligned(size_t Size) { return Size == align(Size); }
+static_assert(aligned(sizeof(void *)));
I think `Size` should be something more
tbaeder created this revision.
tbaeder added reviewers: sepavloff, aaron.ballman.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The last version of this patch created problems because it was using the
