[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd added a comment. @thakis and https://github.com/llvm/llvm-project/issues/59640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 ___ cfe-commits mailing

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

thakis added a comment. (and https://bugs.chromium.org/p/chromium/issues/detail?id=1402885#c3) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 ___ cfe-commits

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

thakis added a comment. We think this is incorrect, see comments here: https://boringssl-review.googlesource.com/c/boringssl/+/55845/3/crypto/refcount_c11.c#18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0c3142af075: Headers: tweak inclusion condition for stdatomic.h (authored by compnerd). Changed prior to commit:

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

Mordante accepted this revision. Mordante added a comment. LGTM after addressing @aaron.ballman's comments. Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 <

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for working on this! The changes LGTM. I've been trying to figure out if there's a way we can add test coverage for this change, but I'm really not coming up with much.

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd updated this revision to Diff 480531. compnerd added a comment. Update to avoid use of the `-0` trick. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 Files: clang/lib/Headers/stdatomic.h Index: clang/lib/Headers/stdatomic.h

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd added inline comments. Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l) # include_next Mordante wrote: > Is `__cplusplus-0`

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

Mordante added a comment. Thanks for the patch! Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l) # include_next Is `__cplusplus-0`

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd created this revision. compnerd added reviewers: aaron.ballman, Mordante, fsb4000. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. MSVC requires that C++23 be available (`_HAS_CXX23`) else the entire content is elided.