[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. vitalybuka marked an inline comment as done. Closed by commit rG166c8cccde01: [msan][CodeGen] Set noundef for C return value (authored by vitalybuka). Repository:

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 !Module.MayDropFunctionReturn(Module.getContext(), RetTy) || Module.getLangOpts().Sanitize.has(SanitizerKind::Memory) ||

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka updated this revision to Diff 480335. vitalybuka added a comment. remove redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

aeubanks added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1828 !Module.MayDropFunctionReturn(Module.getContext(), RetTy) || Module.getLangOpts().Sanitize.has(SanitizerKind::Memory) ||

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

kda accepted this revision. kda added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 ___

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka added a comment. In D139296#3972142 , @kda wrote: > Is there a risk of this being too strict for standard C? > > Should there be a test case for our specific problem? (C calling C++) Probably not. It's cross module mismatch. To reproduce we

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

kda added a comment. Is there a risk of this being too strict for standard C? Should there be a test case for our specific problem? (C calling C++) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka updated this revision to Diff 479992. vitalybuka added a comment. new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139296/new/ https://reviews.llvm.org/D139296 Files: clang/lib/CodeGen/CGCall.cpp

[PATCH] D139296: [msan][CodeGen] Set noundef for C return value

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Msan needs noundef consistency between interface and implementation. If we call C++ from C we can have noundef on C++