This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8effeb44f4a8: Add -Wreturn-local-addr, GCC alias for
-Wreturn-stack-address (authored by adriandole, committed by cjdb).
Repository:
rG LLVM
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM! Do you need someone to commit this on your behalf? If so, what name and
email address would you like for patch attribution?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
adriandole updated this revision to Diff 488699.
adriandole added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139570/new/
https://reviews.llvm.org/D139570
Files:
clang/docs/ReleaseNotes.rst
adriandole updated this revision to Diff 486980.
adriandole added a comment.
Add test and release note.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139570/new/
https://reviews.llvm.org/D139570
Files:
clang/docs/ReleaseNotes.rst
aaron.ballman added a comment.
LGTM as far as the functional changes go, but this should have a release note
and a test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139570/new/
https://reviews.llvm.org/D139570
cjdb accepted this revision.
cjdb added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139570/new/
https://reviews.llvm.org/D139570
___
adriandole created this revision.
Herald added a subscriber: jeroen.dobbelaere.
Herald added a project: All.
adriandole requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D139570