Re: [PATCH] D13959: Fix crash in EmitDeclMetadata mode

2015-11-05 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL252229: Fix crash in EmitDeclMetadata mode (authored by kfischer). Changed prior to commit: http://reviews.llvm.org/D13959?vs=38049=39426#toc Repository: rL LLVM http://reviews.llvm.org/D13959

Re: [PATCH] D13959: Fix crash in EmitDeclMetadata mode

2015-10-22 Thread Pavel Labath via cfe-commits
labath resigned from this revision. labath removed a reviewer: labath. labath added a comment. I'll just observe this one. Someone with more knowledge of clang needs to review this. Repository: rL LLVM http://reviews.llvm.org/D13959 ___

Re: [PATCH] D13959: Fix crash in EmitDeclMetadata mode

2015-10-22 Thread Keno Fischer via cfe-commits
loladiro added a comment. Can you provide insight as to why this is looking at MangledDeclNames rather than the StaticLocalDeclMap? I'd like to extend the comment with an explanation. Repository: rL LLVM http://reviews.llvm.org/D13959 ___

Re: [PATCH] D13959: Fix crash in EmitDeclMetadata mode

2015-10-22 Thread John McCall via cfe-commits
rjmccall added a comment. LGTM. Repository: rL LLVM http://reviews.llvm.org/D13959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13959: Fix crash in EmitDeclMetadata mode

2015-10-21 Thread Keno Fischer via cfe-commits
loladiro created this revision. loladiro added reviewers: rjmccall, labath. loladiro added a subscriber: cfe-commits. loladiro set the repository for this revision to rL LLVM. This fixes a bug that's easily encountered in LLDB (https://llvm.org/bugs/show_bug.cgi?id=22875). The problem here is