[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel closed this revision. ymandel added a comment. Committed: https://reviews.llvm.org/rG01ccf7b3cee58dbe02fd97696cae1781746b6137 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 487506. ymandel added a comment. fix memory error that cause buildbot failures Fixes a self-move assign. This operation should be safe, but is known to cause problems in some implementations of the standard library. The patch drops the assignment, which was

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

xazax.hun accepted this revision. xazax.hun added a comment. I think in these cases you can recommit without waiting for a new round of reviews, but I hit accept just in case :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 486926. ymandel added a comment. fix use-after-free bug in test. Possible cause of buildbot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files:

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel added a comment. I'll revert now and take a look in the morning... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 ___ cfe-commits mailing list

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

paulkirth added a comment. We're seeing a similar breakage on Linux in Fuchsia's Clang CI: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8792772367021497153/overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

thakis added a comment. This breaks tests on Mac: http://45.33.8.238/macm1/52112/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e8f597c2fed: [clang][dataflow] Only model struct fields that are used in the function being… (authored by ymandel). Repository: rG LLVM Github

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 48. ymandel added a comment. fix broken test (from rebase) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files:

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 486659. ymandel marked an inline comment as done. ymandel added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files:

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel marked an inline comment as done. ymandel added a comment. In D140694#4026244 , @xazax.hun wrote: > This is a big improvement, I skimmed through it and looks good to me. There > might be some sneaky ways to change values of fields without

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 486658. ymandel added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files:

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 486657. ymandel added a comment. rebase onto HEAD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files:

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

xazax.hun added a comment. I realized I did not say this explicitly in my previous comment, but feel free to commit :) Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:267 + void addFieldsReferencedInScope(llvm::DenseSet Fields); +

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

xazax.hun accepted this revision. xazax.hun added a comment. This is a big improvement, I skimmed through it and looks good to me. There might be some sneaky ways to change values of fields without mentioning them, e.g., casting a pointer to a struct to an array of chars. But I think reasoning

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel added a comment. Gabor -- do you want to review before I land this patch (Dmitri already accepted it)? thx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel updated this revision to Diff 485393. ymandel added a comment. address comments; fix lifetime bug in new code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140694/new/ https://reviews.llvm.org/D140694 Files:

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:147-148 + // Returns the subset of fields of `Type` that are referenced in

[PATCH] D140694: [clang][dataflow] Only model struct fields that are used in the function being analyzed.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Previously, the model for structs