[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2784b243e38f: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

0x59616e accepted this revision. 0x59616e added a comment. The CI seems OK. My first LGTM is given to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 ___

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

glaubitz added a comment. In D140695#4019189 , @brad wrote: > How come the Clang M68k backend defaults to 68000? GCC defaults to 68020 for > all targets. The Clang M68k is a complete rewrite from scratch, independent of GCC, so it's not surprising you

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad updated this revision to Diff 485582. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 Files: clang/lib/Basic/Targets/M68k.cpp clang/test/Preprocessor/predefined-arch-macros.c Index:

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad added a comment. How come the Clang M68k backend defaults to 68000? GCC defaults to 68020 for all targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

myhsu requested changes to this revision. myhsu added a comment. This revision now requires changes to proceed. In D140695#4018127 , @0x59616e wrote: > FYI the pre-merge checks seem to have some issues. Here is the output: > > Command Output (stderr):

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

0x59616e added a comment. Also, could you add "Fixes #58974" in the commit message so that the item will be closed automatically upon commiting ? Thtanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

0x59616e added a comment. The pre-merge checks seem to have some issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 ___ cfe-commits mailing list

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

glaubitz accepted this revision. glaubitz added a comment. Tested and works as expected. Thanks a lot for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

myhsu accepted this revision. myhsu added a comment. This revision is now accepted and ready to land. LGTM Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad created this revision. brad added reviewers: 0x59616e, myhsu, efriedma, glaubitz. brad added a project: clang. Herald added a project: All. brad requested review of this revision. Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros Repository: rG LLVM Github Monorepo