This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbbe463d6ba26: [OptTable] Make ValuesCode initialisation of
Options constexpr (authored by serge-sans-paille).
Repository:
rG LLVM Github Monorepo
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140699/new/
https://reviews.llvm.org/D140699
___
cfe-commits mailing list
serge-sans-paille updated this revision to Diff 488348.
serge-sans-paille added a comment.
nits + rebased on main
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140699/new/
https://reviews.llvm.org/D140699
Files:
clang/include/clang/Driver/Options.td
nikic added inline comments.
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:268
+if (!isa(R.getValueInit("ValuesCode"))) {
+ assert(!isa(R.getValueInit("Values")) &&
+ "Cannot choose between Values and ValuesCode");
Isn't this assert the
serge-sans-paille added a comment.
Herald added a subscriber: StephenFan.
@nikic: gentle ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140699/new/
https://reviews.llvm.org/D140699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
serge-sans-paille updated this revision to Diff 485932.
serge-sans-paille retitled this revision from "[clang] Make ValuesCode
initialisation of Options constexpr" to "[OptTable] Make ValuesCode
initialisation of Options constexpr".
serge-sans-paille added a comment.
(rebased on main)
CHANGES
