[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman added a comment. In D140794#4160358 , @ccotter wrote: > Thanks both! Assuming this passes build, would one of you mind committing > this for me? `Chris Cotter ` Happy to do so! I've landed it on your behalf in

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdcf5ad89dcc5: [ASTMatcher] Add coroutineBodyStmt matcher (authored by ccotter, committed by aaron.ballman). Repository: rG LLVM Github Monorepo

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter added a comment. Thanks both! Assuming this passes build, would one of you mind committing this for me? `Chris Cotter ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thanks @sammccall for weighing in, I appreciate it. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 500996. ccotter added a comment. fix bad 'arc diff' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 Files: clang/docs/ReleaseNotes.rst

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 500995. ccotter added a comment. - update release note, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 Files: clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

sammccall added a comment. It seems pretty weird to me that the two child edges from functiondecl -> coroutinebodystmt -> compoundstmt are both called "body". However that *is* what they're called in the AST today, and having the matchers correspond to the AST's names seems important. So this

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman added a comment. > Hmmm, I'm coming around to reusing hasBody() like you've done here. I think > it's pretty weird to read: > functionDecl(hasBody(coroutineBodyStmt(hasBody(stmt().bind(...))) because of > the duplicated calls to hasBody, but I think it's more defensible now than

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter added a comment. Bump - anyone else have any thoughts here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 ___ cfe-commits mailing list

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5503 + FunctionDecl, + CoroutineBodyStmt),

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5503 + FunctionDecl, + CoroutineBodyStmt),

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman added a subscriber: sammccall. aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5503 + FunctionDecl, +

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 487789. ccotter added a comment. - Fix ParserTest.Errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 Files: clang/docs/ReleaseNotes.rst

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 487661. ccotter marked an inline comment as not done. ccotter added a comment. - Add hasBody matcher support for coroutineBodyStmt - update doc - Sort list - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5503 + FunctionDecl, + CoroutineBodyStmt),

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman added a comment. Thank you for this! FWIW, it looks like precommit CI found some issues that need to be resolved. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5503 + FunctionDecl, +

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 485748. ccotter added a comment. - Add hasBody matcher support for coroutineBodyStmt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 Files: