This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG00e967f6c2d6: [clang][Interp] Fix left-/right-shifting more
than sizeof(unsigned) (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
tbaeder updated this revision to Diff 491633.
tbaeder marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140845/new/
https://reviews.llvm.org/D140845
Files:
clang/lib/AST/Interp/Integral.h
clang/lib/AST/Interp/Interp.h
clang/test/AST/Interp/shifts.cpp
shafik added inline comments.
Comment at: clang/test/AST/Interp/shifts.cpp:149
+ constexpr signed int R = 62;
+ constexpr decltype(L) M = L << R;
};
Can we add a test for left shift as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We were just casting to `unsigned` before, so
