kkwli0 closed this revision.
kkwli0 added a comment.
Committed revision 253849.
Committed revision 253850.
http://reviews.llvm.org/D14134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D14134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kkwli0 marked 6 inline comments as done.
kkwli0 added a comment.
Address the comments and will post an updated patch.
http://reviews.llvm.org/D14134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kkwli0 updated this revision to Diff 40537.
kkwli0 added a comment.
Updated patch with the 2nd review comments addressed.
http://reviews.llvm.org/D14134
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:2660-2662
@@ +2659,5 @@
+ ///
+ /// \param StartLoc Starting location of the clause.
+ /// \param EndLoc Ending location of the clause.
+ /// \param N Number of the variables in the clause.
+ ///
ABataev added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:2628
@@ +2627,3 @@
+ friend class OMPClauseWriter;
+ friend class Sema;
+
I don't like the idea of friend Sema. If Sema needs some interfaces, they must
be public.
kkwli0 added a comment.
Ping
http://reviews.llvm.org/D14134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kkwli0 created this revision.
kkwli0 added reviewers: ABataev, rsmith, hfinkel, sfantao, fraggamuffin.
kkwli0 added a subscriber: cfe-commits.
This patch is to add parsing and sema support for map clause. This includes
the new map types and the map type modifier added in OpenMP 4.5.
