Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

This revision was automatically updated to reflect the committed changes. Closed by commit rL256887: [analyzer] Fix false warning about memory leak for QApplication::postEvent (authored by zaks). Changed prior to commit: http://reviews.llvm.org/D14170?vs=40596=44070#toc Repository: rL LLVM

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov added a comment. apply all suggestions http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov marked an inline comment as done. Dushistov added a comment. http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov updated this revision to Diff 40485. Dushistov added a comment. Replace 'endswith' with 'operator==', also update test to check that all four ways to call postEvent not produce warning http://reviews.llvm.org/D14170 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

zaks.anna added inline comments. Comment at: test/Analysis/qt_malloc.cpp:11 @@ +10,3 @@ + QCoreApplication::postEvent(obj, event); + QApplication::postEvent(obj, event); +} Should the leak be reported when the object is passed to QApplication::postEvent? In

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! LGTM. I'll commit. http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2514 @@ -2513,1 +2513,3 @@ + if (FName.endswith("postEvent") && + FD->getQualifiedNameAsString() == "QCoreApplication::postEvent") { Shouldn't you use == instead of

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov updated this revision to Diff 39985. Dushistov added a comment. mistype, actually I want to use '&&' here, not '||' to not create std::string, if match failed. http://reviews.llvm.org/D14170 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/Inputs/qt-simulator.h

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov marked an inline comment as done. Dushistov added a comment. http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov updated this revision to Diff 39265. Dushistov added a comment. Fix line length issue http://reviews.llvm.org/D14170 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/Inputs/qt-simulator.h test/Analysis/qt_malloc.cpp Index: test/Analysis/qt_malloc.cpp

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

Dushistov updated this revision to Diff 39264. Dushistov added a comment. I reduce testcase to almost minimal variant. http://reviews.llvm.org/D14170 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/Inputs/qt-simulator.h test/Analysis/qt_malloc.cpp Index:

Re: [PATCH] D14170: Fix false positive warning about memory leak for QApplication::postEvent

zaks.anna added a comment. This needs a test case. You can either extend ./test/Analysis/malloc.cpp or add another QT specific test file. Thanks! Anna. http://reviews.llvm.org/D14170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org