[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5a7439e220c: [HLSL] [Dirver] add dxv as a VerifyDebug Job (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687 +def warn_drv_dxc_missing_dxv : Warning<"dxv not found." +" Resulting DXIL will not be signed for use in release environments.">; MaskRay wrote: >

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 493149. python3kgae marked 2 inline comments as done. python3kgae added a comment. add space for warning message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

MaskRay added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687 +def warn_drv_dxc_missing_dxv : Warning<"dxv not found." +" Resulting DXIL will not be signed for use in release environments.">; python3kgae wrote: > beanz

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/Driver/dxc_dxv_path.hlsl:7 +// RUN: echo "dxv" > %T/dxv && chmod 754 %T/dxv && %clang_dxc --dxv-path=%T %s -Tlib_6_3 -### 2>&1 | FileCheck %s --check-prefix=DXV_PATH +//

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492941. python3kgae marked 2 inline comments as done. python3kgae added a comment. Fix windows test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705 Files:

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM overall. Thanks for the patch. Others feel free to comment. Comment at: clang/lib/Driver/Driver.cpp:4214 } - + // Call validator for dxil when -Vd not in Args. +

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:170 + +Tool *clang::driver::toolchains::HLSLToolChain::getTool( +Action::ActionClass AC) const { jhuber6 wrote: > python3kgae

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492931. python3kgae marked an inline comment as done. python3kgae added a comment. rename to requiresValidation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:170 + +Tool *clang::driver::toolchains::HLSLToolChain::getTool( +Action::ActionClass AC) const { python3kgae wrote: > jhuber6 wrote: > > I feel like this logic should go with the

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4226 +Args.ClaimAllArgs(options::OPT_cl_ignored_Group); + } jhuber6 wrote: > nit. remember to `clang-format` arc did find some

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added a comment. Thanks for the changes. Comment at: clang/lib/Driver/Driver.cpp:4226 +Args.ClaimAllArgs(options::OPT_cl_ignored_Group); + } nit. remember to `clang-format` Comment at: clang/lib/Driver/ToolChains/HLSL.cpp:170

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4217-4218 +// Only add action when needValidation. +const auto = getToolChain(Args, C.getDefaultToolChain().getTriple()); +const auto *HLSLTC = static_cast(); +if

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492912. python3kgae marked 2 inline comments as done. python3kgae added a comment. switch to getDefaultToolChain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/ https://reviews.llvm.org/D141705

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4217-4218 +// Only add action when needValidation. +const auto = getToolChain(Args, C.getDefaultToolChain().getTriple()); +const auto *HLSLTC = static_cast(); +if

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492894. python3kgae marked 2 inline comments as done. python3kgae added a comment. cast ToolChain to HLSLToolChain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 6 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Driver/Types.def:110 TYPE("api-information", API_INFO, INVALID, "json", phases::Precompile) +TYPE("dx-container", DX_CONTAINER,

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/test/Driver/dxc_dxv_path.hlsl:19-23 +// PHASES:+- 0: input, "[[INPUT:.+]]", hlsl +// PHASES:+- 1: preprocessor, {0}, c++-cpp-output +// PHASES:+- 2: compiler, {1}, ir +// PHASES:3: backend, {2}, assembler +// PHASES:4:

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4218 +// Only add action when needValidation. +if (toolchains::HLSLToolChain::needValidation(Args, *this, + C.getDefaultToolChain())) {

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4218 +// Only add action when needValidation. +if (toolchains::HLSLToolChain::needValidation(Args, *this, +

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4214-4216 + // Call validator for dxil when -Vd not in Args. + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil) { Comment at:

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

beanz added inline comments. Comment at: clang/include/clang/Driver/Types.def:110 TYPE("api-information", API_INFO, INVALID, "json", phases::Precompile) +TYPE("dx-container", DX_CONTAINER, INVALID, "dxc", phases::Compile,

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4216 + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil && !Args.getLastArg(options::OPT_dxc_disable_validation)) { +// Only

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492878. python3kgae marked 9 inline comments as done. python3kgae added a comment. add DX_CONTAINER Driver type. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141705/new/

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4216 + llvm::Triple T(getTargetTriple()); + if (T.getArch() == llvm::Triple::dxil && !Args.getLastArg(options::OPT_dxc_disable_validation)) { +// Only add action when 'dxv' exists.

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae marked 2 inline comments as done. python3kgae added a comment. In D141705#4082935 , @jhuber6 wrote: > I'm not overly familiar with HLSL or DirectX here. Most of the changes are > purely mechanical, but I don't see anywhere we create the

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

python3kgae updated this revision to Diff 492559. python3kgae marked an inline comment as done. python3kgae added a comment. Only create dxv job when 'dxv' exist. Test ccc-print-bindings. Code cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

beanz added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:687 +def warn_drv_dxc_missing_dxv : Warning<"dxv not found." +" Resulting DXIL will not be signed for use in release environments.">; Not all `dxv` binaries can

[PATCH] D141705: [HLSL] [Dirver] add dxv as a Driver Action Job

jhuber6 added a comment. I'm not overly familiar with HLSL or DirectX here. Most of the changes are purely mechanical, but I don't see anywhere we create the tool. Does that come later? Normally you'd test these with `-ccc-print-bindings`, `-ccc-print-bindings`, and `-###`.