[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-20 Thread Bryan Chan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG275ab246ee81: [Clang][test] Avoid FileCheck error when matching `-cc1` (authored by hezuoqiang hezuoqia...@huawei.com, committed by bryanpkc).

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-20 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc accepted this revision. bryanpkc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141886/new/ https://reviews.llvm.org/D141886

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-17 Thread hezuoqiang via Phabricator via cfe-commits
hzq added a comment. @bryanpkc Modified, Thanks for detailed guidance.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141886/new/ https://reviews.llvm.org/D141886 ___ cfe-commits mailing list

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-17 Thread hezuoqiang via Phabricator via cfe-commits
hzq updated this revision to Diff 489995. hzq marked an inline comment as not done. hzq added a comment. Update the check content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141886/new/ https://reviews.llvm.org/D141886 Files:

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-17 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc requested changes to this revision. bryanpkc added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/modules-ts.cpp:23 // -// CHECK-USE: -cc1 +// CHECK-USE: -cc1{{[^[:xdigit:]]}} // CHECK-USE-SAME: -emit-obj

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-16 Thread hezuoqiang via Phabricator via cfe-commits
hzq marked an inline comment as done. hzq added a comment. In D141886#4057549 , @bryanpkc wrote: > Thanks for the patch. I just have some simple suggestions. Thanks a lot, modified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141886: [Clang][test] Avoid FileCheck error when matching `-cc1`

2023-01-16 Thread hezuoqiang via Phabricator via cfe-commits
hzq updated this revision to Diff 489705. hzq retitled this revision from "[Clang][Test] Avoid matching version numbers" to "[Clang][test] Avoid FileCheck error when matching `-cc1`". hzq added a comment. Add `-###` to the command line and update the check content. Repository: rG LLVM Github