[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545332. ccotter added a comment. - Fix ReleaseNotes again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545331. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. bump - @njames93 let me know if you have any further feedback. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 ___ cfe-commits

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. Addressed all comments except for the `handleReturnType` one which I responded to - let me know your thoughts, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 520125. ccotter added a comment. - Better handling for ctor inits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:247-248 +ParamsRange.getEnd(), SM, LangOpts, tok::r_paren, tok::r_paren); +return

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 520104. ccotter marked 3 inline comments as done. ccotter added a comment. Fix bug, other cleanups, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:63-65 +std::string Name = TheType.getType().getAsString(); +if (Name.find("enable_if<") == std::string::npos) + return std::nullopt; This

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 512315. ccotter added a comment. arc diff properly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 512314. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 512313. ccotter added a comment. refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. > Would you consider supporting enable_if via parameters I was planning to support those too, but in a subsequent commit / review since this review is rather large. Is that OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141892: Implement modernize-use-constraints

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:157-160 +return std::make_tuple( +matchEnableIfSpecialization( +LastTemplateParam->getTypeSourceInfo()->getTypeLoc()), +LastTemplateParam);

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 512308. ccotter marked 12 inline comments as done. ccotter added a comment. feedback+rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

njames93 added a reviewer: carlosgalvezp. njames93 added a comment. Would you consider supporting enable_if via parameters template void doStuff(T&, std::enable_if_t = nullptr) {} Comment at: clang-tools-extra/clang-tidy/modernize/UseConstraintsCheck.cpp:71 + +return

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 509544. ccotter added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 509543. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 508452. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 506339. ccotter added a comment. Herald added a subscriber: PiotrZSL. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. This is more or less ready for review (not planning on making any further changes; there are more features to be added, but I was thinking of handling those in follow up changesets). I know it's a relatively large review, but let me know if anyone can take a first

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 493050. ccotter added a comment. Rebase + Simplify match logic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 491201. ccotter added a comment. - Use nested namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 491127. ccotter added a comment. - Add fno-delayed-template-parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. In D141892#4058273 , @njames93 wrote: > In D141892#4057722 , @ccotter wrote: > >> 2. replace the non `_v` templates to the `_v` variants `is_same` -> >> `is_same_v` or the equivalent

[PATCH] D141892: Implement modernize-use-constraints

njames93 added a comment. In D141892#4057722 , @ccotter wrote: > 2. replace the non `_v` templates to the `_v` variants `is_same` -> > `is_same_v` or the equivalent concept `same_as` See D137302 Repository: rG

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. Overall, we could eventually upgrade code in three stages, each a separate reusable check. 1. enable_if -> requires clauses 2. replace the non `_v` templates to the `_v` variants `is_same` -> `is_same_v` or the equivalent concept `same_as` 3. replace requires clause on

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. For the sake of demonstration, https://github.com/llvm/llvm-project/commit/9c556ce59edf5a4293d4497d5815544afc0eb878 is the result of running this tool on all headers under clang/include/clang and llvm/include/llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D141892: Implement modernize-use-constraints

ccotter created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add new check to replace enable_if