tbaeder added a comment.
All the interpreter work is experimental so it doesn't really need to be in the
release branch. This should all be fine, thanks for asking.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142328/new/
steakhal added a comment.
Hi @tbaeder, I was looking for commits that mentions "fix" "assertion" or
"crash" in the title, that are part of the `main` branch but not backported to
`release/16.x` to be eventually released as `clang-16`.
I wonder what's the status of this and the related patches
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGde3a3cb987f1: [clang][Interp] Fix compound assign operator
types (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
tbaeder added a comment.
Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142328/new/
https://reviews.llvm.org/D142328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142328/new/
https://reviews.llvm.org/D142328
___
cfe-commits mailing list
tbaeder added a comment.
I know it hasn't been a week yet, but can someone take a look at this? It would
unblock pushing more of the approved patches.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142328/new/
https://reviews.llvm.org/D142328
tbaeder updated this revision to Diff 491238.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142328/new/
https://reviews.llvm.org/D142328
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp
tbaeder added a comment.
The casts emitted are similar to https://reviews.llvm.org/D140377 now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142328/new/
https://reviews.llvm.org/D142328
___
cfe-commits
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Just like we do (or will do) for floating types,