[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

2023-01-23 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli updated this revision to Diff 491506. fpetrogalli added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1. Herald added a project: LLVM. Address code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

2023-01-23 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. In D142403#4074905 , @fpetrogalli wrote: > In D142403#4074885 , @tstellar > wrote: > >> This is still the wrong change IMO. I don't know, maybe I'm not being >> clear, but I don't

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

2023-01-23 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added a comment. In D142403#4074885 , @tstellar wrote: > This is still the wrong change IMO. I don't know, maybe I'm not being clear, > but I don't 'think you ever actually tried my suggestion in D141581 >

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

2023-01-23 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. This is still the wrong change IMO. I don't know, maybe I'm not being clear, but I don't 'think you ever actually tried my suggestion in D141581 which was to leave the RISCVTargetParserTableGen Depends as is and add the pseudo

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

2023-01-23 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli created this revision. fpetrogalli added reviewers: mgorny, tstellar. Herald added subscribers: luismarques, s.egerton, kadircet, PkmX, simoncook, arichardson. Herald added a project: All. fpetrogalli requested review of this revision. Herald added subscribers: cfe-commits,