[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd6d59e660bc7: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a… (authored by shafik). Herald added a project: clang.

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 498510. shafik added a comment. - Add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/TokenLexer.cpp

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

ldionne added a comment. I suspect the libc++ failure is because the patch is not rebased onto `main`. I remember seeing those issues a while back. I think it's unlikely to be this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

aaron.ballman added subscribers: Mordante, ldionne. aaron.ballman added a comment. I don't think the libc++ precommit CI failures are related to this change and so I don't think they block anything, but it'd be nice if a libc++ person could verify (CC @ldionne @Mordante ) CHANGES SINCE LAST

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM but please add a release note for the fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 ___ cfe-commits mailing list

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

erichkeane added subscribers: cor3ntin, tahonermann. erichkeane added a comment. Pretty sure @cor3ntin and @tahonermann are our Lexer code owners? Or at least were in the initial proposal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik added a comment. It looks like the modules test failures are unrelated and are failing all the recent modules builds. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 ___ cfe-commits mailing

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492589. shafik added a comment. - Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vaopt_p1042r1.cpp Index:

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik added inline comments. Comment at: clang/test/Preprocessor/macro_vaopt_p1042r1.cpp:1 - RUN: %clang_cc1 -E %s -pedantic -std=c++2a | FileCheck -strict-whitespace %s - I removed Windows lines ending from this test, I don't think they matter but if someone

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492562. shafik added a comment. - I think I correctly updated line endings this time CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik updated this revision to Diff 492560. shafik added a comment. - Update line ending in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142604/new/ https://reviews.llvm.org/D142604 Files: clang/lib/Lex/TokenLexer.cpp clang/test/Preprocessor/macro_vaopt_p1042r1.cpp Index:

[PATCH] D142604: [Clang] Fix __VA_OPT__ implementation so that it treats the concatenation of a non-placemaker token and placemaker token as a non-placemaker token

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, hubert.reinterpretcast. Herald added a project: All. shafik requested review of this revision. Currently the implementation of `__VA_OPT__` will treat the concatenation of a non-placemaker token and placemaker token