[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b50bfc8f25a: [clang] Store the template param list of an explicit variable template… (authored by nridge). Repository: rG LLVM Github Monorepo

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. sorry for the delay, just started unburying myself from the 16.0 release process. Its unfortunate we don't have a great way to test this, but I can see the value of having it anyway

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142692/new/ https://reviews.llvm.org/D142692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

nridge added a comment. In D142692#4090867 , @erichkeane wrote: > We have a good amount of AST-dump tests around that are likely the right > place to put them perhaps? What is the reproducer that caused you to > discover this issue? The following is

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

erichkeane added a comment. We have a good amount of AST-dump tests around that are likely the right place to put them perhaps? What is the reproducer that caused you to discover this issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

shafik added subscribers: clang-language-wg, shafik. shafik added a comment. Adding `clang-language-wg` for more visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142692/new/ https://reviews.llvm.org/D142692

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

nridge added a comment. So far the only test I added is in clangd semantic highlighting because that's how I noticed the `template<>` missing from the AST, but I'm open to suggestions on where to add a test at the clang layer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142692: [clang] Store the template param list of an explicit variable template specialization

nridge created this revision. nridge added reviewers: rsmith, mizvekov. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits.